fix(gemini): strip propertyNames from tool schemas#3426
Open
pascalwhoop wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strip
propertyNamesfrom Gemini tool schemas to avoid Google API 400 errors for unsupported function declaration fields.Context
Gemini function declarations use an OpenAPI-style schema subset and reject some JSON Schema keywords. Tool schemas that include
propertyNamescan currently fail with errors like:I found this when trying to get 3.5-flash going
additionalPropertiesand other unsupported keywords are already removed by the Gemini schema sanitizer; this adds the missingpropertyNamescase.Changes
propertyNamesto the unsupported keyword list removed from Gemini schemaspropertyNamesentries are absent from the serialized sanitized schema