Allow AdvertiseTags to be passed to tsnet.Server#116
Merged
willnorris merged 2 commits intotailscale:mainfrom Nov 17, 2025
Merged
Allow AdvertiseTags to be passed to tsnet.Server#116willnorris merged 2 commits intotailscale:mainfrom
willnorris merged 2 commits intotailscale:mainfrom
Conversation
Signed-off-by: Chris Hoage <iam@chrishoage.com>
a7a910f to
dc7161e
Compare
Signed-off-by: Chris Hoage <iam@chrishoage.com>
dc7161e to
7191b0b
Compare
Member
|
man, this looks great! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
This PR Bumps the tsnet go module to v1.90.6 to include tailscale/tailscale@b9cda4b
This update allows tsnet to accept oauth client secrets to be passed in place of the auth key.
This also takes advantage of tailscale/tailscale#8531 to allow setting arbitrary advertise tags.
Both of these allow for a minimal change set to close the PR
I suppose this MR would supersede #109
I did this for my own caddy-tailscale use, but figured opening the PR may be worth while. I applied the feedback in the linked PR along with adding some tests
{ log tailscale { level DEBUG } tailscale { ephemeral tags tag:test tag:container test-caddy { port 41650 } other-caddy { port 41651 tags tag:test tag:test-sub } more-other-caddy { port 41652 } } } :80 { bind tailscale/test-caddy respond OK } :80 { bind tailscale/other-caddy respond OK } :80 { bind tailscale/more-other-caddy respond OK }I have validated these changes function as expected