Skip to content

add ubuntu-slim to OS matrix#289

Closed
jaxxstorm wants to merge 3 commits intomainfrom
ubuntu-slim
Closed

add ubuntu-slim to OS matrix#289
jaxxstorm wants to merge 3 commits intomainfrom
ubuntu-slim

Conversation

@jaxxstorm
Copy link
Copy Markdown
Contributor

Signed-off-by: Lee Briggs lee@leebriggs.co.uk

Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Copilot AI review requested due to automatic review settings April 25, 2026 16:02
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an additional OS entry to the GitHub Actions smoke test matrix to expand coverage.

Changes:

  • Extend the smoke-test job OS matrix to include ubuntu-slim.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-latest, macos-latest, ubuntu-slim]
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-slim is not a valid GitHub-hosted runner label, and this repo doesn’t appear to use self-hosted runners in workflows. As written, jobs using this matrix entry will fail to start with an unsupported runner label. If the intent is to test a slimmer Linux environment, use a supported runs-on value (e.g., ubuntu-latest/ubuntu-24.04) and run the job inside a container image; if the intent is a self-hosted runner, switch runs-on to an array including self-hosted plus the custom label and ensure such a runner exists.

Suggested change
os: [ubuntu-latest, windows-latest, macos-latest, ubuntu-slim]
os: [ubuntu-latest, windows-latest, macos-latest, ubuntu-24.04]

Copilot uses AI. Check for mistakes.
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
@jaxxstorm jaxxstorm closed this Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants