Skip to content

Add an install type homebrew for OS X runners#290

Open
jaxxstorm wants to merge 6 commits intomainfrom
osx_homebrew
Open

Add an install type homebrew for OS X runners#290
jaxxstorm wants to merge 6 commits intomainfrom
osx_homebrew

Conversation

@jaxxstorm
Copy link
Copy Markdown
Contributor

Signed-off-by: Lee Briggs lee@leebriggs.co.uk

Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Copilot AI review requested due to automatic review settings April 27, 2026 02:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Homebrew-based install path for macOS runners, with CI coverage to exercise both the Homebrew and “build from source” fallback flows.

Changes:

  • Add macOS install logic that prefers Homebrew when available and matches the requested version; otherwise fall back to building from source.
  • Start tailscaled via brew services when installed with Homebrew and skip caching for Homebrew-managed installs.
  • Add smoke/unit-style tests and update workflows to exercise both macOS install types and run local smoke tests in CI.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/main.ts Implements Homebrew availability/version checks, Homebrew install path, and Homebrew service start logic; adjusts install return type for downstream decisions (cache/start).
test/macos-homebrew.test.js Adds source/bundle string-match tests to assert the Homebrew logic is present in src/main.ts and the bundled action.
package.json Adds test and test:smoke scripts (build + Node test runner).
.github/workflows/test.yml Extends matrix with an explicit install-type and adds steps to resolve the Homebrew formula version / force the source path; verifies the chosen path.
.github/workflows/smoke-test.yml Runs npm test (build + local smoke tests) instead of only building.
dist/logout/index.js Re-bundled output update (generated artifact).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main.ts Outdated
Comment thread src/main.ts Outdated
Comment thread src/main.ts Outdated
Comment thread src/main.ts
Comment thread .github/workflows/test.yml Outdated
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants