Skip to content

Update action to cache the gitops-pusher binary#61

Open
evilhamsterman wants to merge 2 commits intotailscale:mainfrom
evilhamsterman:main
Open

Update action to cache the gitops-pusher binary#61
evilhamsterman wants to merge 2 commits intotailscale:mainfrom
evilhamsterman:main

Conversation

@evilhamsterman
Copy link
Copy Markdown

Compiling the binary every time causes the action to take longer to run the job than it should. This updates the action to instead of using go run it uses go install and then caches the binary after it's built. On future runs the binary is restored from cache making the job run in only a few seconds versus minutes.

This should fix #56 at least the build time concern.

Copy link
Copy Markdown

@joneskoo joneskoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good that the original action pins a specific gitops-pusher version. Using a dynamic version like this would make useless pinning to the action commit sha. Also, what about cache poisoning attack risk?

@jaxxstorm
Copy link
Copy Markdown

@joneskoo thanks for your input, the comments on months old PRs unfortunately aren't providing a lot of value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thoughts on container-based action?

3 participants