README: use environment for apply#77
Draft
joneskoo wants to merge 1 commit intotailscale:mainfrom
Draft
Conversation
A collaborator with write access to repository can modify workflow and use repository secrets or OIDC to abuse CI/CD privileges. This allows bypassing branch protection required review through workflow modification. For example, if main branch requires review but pull requests are allowed. Split into two jobs: - acls: runs only on push, uses environment: production. The environment must be restricted to the main branch so its secrets cannot be accessed from a PR branch regardless of workflow modifications. - acls-test: runs only on pull_request, uses a separate read-only federated identity (policy_file:read scope) so it cannot apply changes. This relies on the OIDC trust also enforcing the environment. Fixes tailscale#32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collaborator with write access to repository can modify workflow and use repository secrets or OIDC to abuse CI/CD privileges. This allows bypassing branch protection required review through workflow modification. For example, if main branch requires review but pull requests are allowed.
Split into two jobs:
This relies on the OIDC trust also enforcing the environment.
Fixes #32.
AI assistance used to generate the pull request.