Skip to content

path{.go,._test.go}: catch staticcheck.conf lookups above @ #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
irbekrm merged 1 commit into from
Jan 20, 2026
Merged

path{.go,._test.go}: catch staticcheck.conf lookups above @ #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions path.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,16 @@ func parsePath(name string) (ret gmPath) {
ret.NotExist = true
return
}

// staticcheck walks the directory, looking for staticcheck.conf and
// does not stop at '@' - make sure we don't tell it that there is a
// foo/bar/staticcheck.conf directory that it will then attempt to parse
// as its config file.
// https://github.com/tailscale/gomodfs/issues/17
if base == "staticcheck.conf" {
ret.NotExist = true
return
}
return
}
escVer, path, _ := strings.Cut(verAndPath, "/")
Expand Down
20 changes: 20 additions & 0 deletions path_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,26 @@ var pathTests = []struct {
{path: "foo/bar", want: gmPath{}},
{path: "foo/bar/baz", want: gmPath{}},
{path: "foo/bar/baz", want: gmPath{}},

// https://github.com/tailscale/gomodfs/issues/17
{path: "github.com/go4.org/staticcheck.conf", want: gmPath{NotExist: true}},
{path: "github.com/go4.org/mem/staticcheck.conf", want: gmPath{NotExist: true}},
{
path: "github.com/go4.org/mem@v2.17.2/staticcheck.conf",
want: gmPath{
ModVersion: store.ModuleVersion{Module: "github.com/go4.org/mem", Version: "v2.17.2"},
InZip: true,
Path: "staticcheck.conf",
},
},
{
path: "github.com/go4.org/mem@v2.17.2/foo/bar/staticcheck.conf",
want: gmPath{
ModVersion: store.ModuleVersion{Module: "github.com/go4.org/mem", Version: "v2.17.2"},
InZip: true,
Path: "foo/bar/staticcheck.conf",
},
},
{
path: "github.com/tailscale/web-client-prebuilt@v0.0.0-20250124233751-d4cd19a26976/build/", // with trailing slash
want: gmPath{
Expand Down