Skip to content

Allow opting out of Slack notifications for some access configs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awly merged 1 commit into from
Dec 4, 2025
Merged

Allow opting out of Slack notifications for some access configs #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions hallpass.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ type accessTypeConfig struct {
Attr string // e.g. "custom:jitToPII" (posture attribute key)
Max timeDurationString
Default timeDurationString
Silent bool // when true, skip Slack notifications for access requests
}

type accessTypes struct {
Expand Down Expand Up @@ -532,15 +533,17 @@ func (s *Server) authorize(ctx context.Context, li lookupInfo, req authorizeRequ
if err != nil {
return fmt.Errorf("SetPostureAttribute: %v", err)
}
if err := SendSlack(ctx, string(s.webhookURL()), SlackNotification{
Who: li.Who,
NodeID: li.NodeID,
NodeName: li.NodeName,
AccessType: at.Name,
AccessDuration: req.Duration.String(),
Reason: req.Reason,
}); err != nil {
return fmt.Errorf("SendSlack: %v", err)
if !at.Silent {
if err := SendSlack(ctx, string(s.webhookURL()), SlackNotification{
Who: li.Who,
NodeID: li.NodeID,
NodeName: li.NodeName,
AccessType: at.Name,
AccessDuration: req.Duration.String(),
Reason: req.Reason,
}); err != nil {
return fmt.Errorf("SendSlack: %v", err)
}
}
return nil
}
Expand Down