client/setec: add a Keyring type#161
Merged
creachadair merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
creachadair
force-pushed
the
mjf/keyring-nova
branch
from
55ae905 to
c96fb4c
Compare
Introduce a new Keyring type to the client library, representing a collection of all the available versions of a secret. The Keyring allows the caller to get any of the versions known explicitly (as Client.GetVersion) without an additional fetch from the service, or to get the ID and value of the "active" version explicitly. A Keyring also supports an Update operation which polls the server for changes, allowing the caller to observe additional versions and changes to the active version ID. - Add a new method GetKeyring to the Client to fetch a keyring. - Update tests and documentation.
creachadair
force-pushed
the
mjf/keyring-nova
branch
from
d46e74a to
3cf229a
Compare
sfarqu
approved these changes
Mar 10, 2026
sfarqu
left a comment
sfarqu
left a comment
There was a problem hiding this comment.
Looks good, as per prior discussions about requirements for corp/37369.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new Keyring type to the client library, representing a collection
of all the available versions of a secret. The Keyring allows the caller to get
any of the versions known explicitly (as Client.GetVersion) without an
additional fetch from the service, or to get the ID and value of the "active"
version explicitly.
A Keyring also supports an Update operation which polls the server for changes,
allowing the caller to observe additional versions and changes to the active
version ID.
This commit does not integrate the Keyring type into the Store.
Doing so will be the task of a future change.