(WIP) Add a "description" field to each stored secret#164
Draft
creachadair wants to merge 8 commits intomjf/audit-readfrom
Draft
(WIP) Add a "description" field to each stored secret#164creachadair wants to merge 8 commits intomjf/audit-readfrom
creachadair wants to merge 8 commits intomjf/audit-readfrom
Conversation
creachadair
force-pushed
the
mjf/description
branch
from
c0d457e to
8c0fd80
Compare
creachadair
commented
Apr 27, 2026
|
|
||
| // MaxDescriptionBytes is the maximum permitted length of a secret description. | ||
| // Descriptions in excess of this length will be rejected. | ||
| const MaxDescriptionBytes = 1000 |
Member
Author
There was a problem hiding this comment.
Rationale: About 12 lines or 200 words of English text, should be enough for anybody.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #163 and requires it to be merged first.
There are multiple commits here that can be reviewed separately, and the branch
is currently based on the #163 branch, but I intend to rebase it on main before
requesting a real review.
NOT READY -- DO NOT MERGE