Repository navigation
Conversation
Without hysteresis, a peer that flaps or a pool whose members become reachable one at a time on startup moves keys around on every change. RouterConfig adds two delays. JoinDelay holds newly reachable peers out of the table until that long after the latest one appeared, so members discovered seconds apart are adopted together and ownership changes once. LeaveDelay keeps an unreachable member in the table that long before reassigning its keys; meanwhile Pick reports those keys as the local process's to handle, so a restart or short outage neither moves keys away nor back. Zero delays adopt and reassign immediately, as before. Updates tailscale/corp#48514 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Change-Id: I2d7a9e4b1c6f8035e9a2b7d4c1f0e3a6b8d5c290
A loop over probe rounds hid what each wait was for. Each call site now sleeps for an explicit duration and says why that much. Updates #cleanup Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Change-Id: I5c1e8f2a9d3b7046c0e4a8f1b2d6c9e3a7f0b418
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A loop over probe rounds hid what each wait was for. Each call site now
sleeps for an explicit duration and says why that much.
Updates #cleanup