fix(deps): resolve open Dependabot alerts - #47
Merged
Conversation
Pin esbuild to 0.28.1 in both lockfiles. tsup 8.5.1 declares esbuild ^0.27.0, so the pin needs pnpm.overrides for pnpm-lock.yaml and overrides for package-lock.json. Raise the postcss override from 8.5.18 to 8.5.23. Regenerate package-lock.json with npm. The previous lockfile did not satisfy the vite 8.0.16 pin in package.json, so npm ci failed on main. Closes Dependabot alerts #17, #30, #44.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the three open Dependabot alerts. No alert is dismissed.
Changes
package.json: addesbuild: 0.28.1topnpm.overridesand to npmoverrides. tsup 8.5.1 declaresesbuild ^0.27.0, so neither lockfile can reach 0.28.x without the pin. vite 8.0.16 accepts^0.27.0 || ^0.28.0.package.json: raise thepostcssoverride from 8.5.18 to 8.5.23 (first patched version).pnpm-lock.yaml: regenerated withpnpm install. Only esbuild,@esbuild/*, and postcss entries change.package-lock.json: regenerated withnpm install --package-lock-only --ignore-scripts. The lockfile onmaindid not satisfy thevite: 8.0.16pin inpackage.json(npm cifails withlock file's vite@8.2.2 does not satisfy vite@8.0.16), so npm also moves vite 8.2.2 -> 8.0.16 and its rolldown dependencies to match the manifest. package-lock.json postcss stays at 8.5.26 (already patched).Verification
All commands run from the branch with Node 22.21.0, pnpm 10.28.0, npm 10.9.4.
pnpm install --frozen-lockfilepnpm run typecheckpnpm run testpnpm run buildpnpm auditnpm ci --dry-run --ignore-scriptsgit merge-tree --write-tree origin/main HEADResolved versions in
pnpm-lock.yaml:esbuild@0.28.1,postcss@8.5.23.Resolved versions in
package-lock.json(npm ls --package-lock-only):esbuild@0.28.1 overridden,postcss@8.5.26,vite@8.0.16.Note
The repository tracks two lockfiles (
pnpm-lock.yaml,package-lock.json) while CI andpackageManageruse pnpm only. Each advisory produces two alerts, and npm does not readpnpm.overrides, so the two lockfiles drift. Droppingpackage-lock.jsonwould remove the duplicate alert stream; that is a separate decision and is not part of this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_01Hd9Ww3YmftNEs9DnRtQQ84