refactor(knowledge): isolate visibility snapshots - #202
Merged
Conversation
Contributor
Author
|
Independent source review completed by the coordinating agent at 4dfdac5: approved. The visibility cache retains one owner, public declarations stay in the receipt facade, and the implementation uses type-only imports for those declarations. No runtime initialization cycle or public API change was found. Both exact-head CI checks passed; latest comments, submitted reviews, and inline comments contain no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The receipt module combined receipt creation and joins with visibility snapshot encoding, validation, and indexing. Extract snapshot implementation into
knowledge-visibility.ts, keeping the public contracts and exports in the existing receipt facade.The snapshot cache has one owner. Function bodies, canonical digests, and the public API inventory remain unchanged. The receipt module decreases from 1,266 to 964 lines.
Validation: Linux full suite passed (88 files, 867 tests, 12 skipped), with typecheck, lint, and build passing. After retaining the original public declaration ownership, typecheck, build, and the complete package verification passed, including the unchanged API inventory and clean packed installation. Focused receipt/retrieval tests passed (31 tests). macOS exact-candidate failures reproduced on unchanged main because those tests require Linux; Linux passed those paths.