docs(tangle): supply explicit sandbox URLs in examples - #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four Tangle provider README examples omit
baseUrl, so the supported Sandbox 0.37.0 constructor throwsBase URL is requiredbefore creating a client.Supply an explicit public Sandbox URL in each example, with
TANGLE_SANDBOX_URLpreserving caller configuration. Explain the required field. This changes documentation only.Validation: reproduced the original constructor error locally with published Sandbox 0.37.0. Extracted and executed all four corrected README constructors with both absent and custom endpoint settings: all eight endpoint assertions passed without network calls.
git diff --checkand commit/push hooks passed.