Skip to content

fix(vite): merge @radix-ui into react chunk to break load-order cycle (prod hotfix) #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewstone merged 1 commit into from
May 14, 2026
Merged

fix(vite): merge @radix-ui into react chunk to break load-order cycle (prod hotfix) #3204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions apps/tangle-cloud/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,23 @@ export default defineConfig({
if (id.includes('viem')) return 'viem';
if (id.includes('@tanstack')) return 'tanstack';
if (id.includes('react-router')) return 'router';
// Co-locate react/react-dom with @radix-ui. Splitting them lets
// Rollup hoist the CJS-interop helper (`_getDefaultExportFromCjs`)
// into whichever chunk evaluates first; on some content-hash
// layouts the helper landed in the radix chunk and the react
// chunk imported it back, forming a load-order cycle that
// crashed the app at module init with
// `Cannot read properties of undefined (reading 'forwardRef')`
// when radix's top-level `Qu.reduce(...)` ran before react's
// bindings had initialised. Co-resident avoids the cycle since
// radix depends on react and must evaluate after it anyway.
if (
id.includes('node_modules/react/') ||
id.includes('node_modules/react-dom/')
id.includes('node_modules/react-dom/') ||
id.includes('@radix-ui')
) {
return 'react';
}
if (id.includes('@radix-ui')) return 'radix';
return undefined;
},
},
Expand Down
11 changes: 9 additions & 2 deletions apps/tangle-dapp/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,20 @@ export default defineConfig({
if (id.includes('node_modules/globalthis/')) return 'utils';
if (id.includes('@tanstack')) return 'tanstack';
if (id.includes('react-router')) return 'router';
// Co-locate react/react-dom with @radix-ui. See tangle-cloud's
// vite.config.ts for the full incident write-up — splitting
// react from radix lets Rollup hoist the CJS-interop helper
// into the radix chunk, forming a load-order cycle that crashes
// the app with `Cannot read properties of undefined (reading
// 'forwardRef')` when radix's top-level `Qu.reduce(...)` runs
// before react's bindings have initialised.
if (
id.includes('node_modules/react/') ||
id.includes('node_modules/react-dom/')
id.includes('node_modules/react-dom/') ||
id.includes('@radix-ui')
) {
return 'react';
}
if (id.includes('@radix-ui')) return 'radix';
return undefined;
},
},
Expand Down
Loading