Skip to content

chore: retire staging branch, document develop → master flow#3208

Merged
drewstone merged 1 commit into
developfrom
chore/retire-staging-branch
May 14, 2026
Merged

chore: retire staging branch, document develop → master flow#3208
drewstone merged 1 commit into
developfrom
chore/retire-staging-branch

Conversation

@drewstone
Copy link
Copy Markdown
Contributor

The `staging` branch has been vestigial for some time: `auto-sync-master-with-develop.yml` already promotes develop to master on every `[RELEASE]`-tagged commit, so the develop → staging → master hop only added merge artifacts. Recent history is full of post-merge cleanups attributable to staging drift:

  • `a725b00ad fix: remove staging-only web3-api-provider files not present in develop`
  • `cff4de8c5 fix: restore api-config.ts to develop version (staging merge artifact)`
  • `81bac419c fix: restore ChainListCard to develop version (duplicate sortedChains from merge)`
  • `c46c77a55 style: prettier fix staging merge conflicts`

The latest production incident (`cloud.tangle.tools` forwardRef crash, #3204) was triggered by exactly this kind of staging-merge rebuild surfacing a latent chunk-cycle bug — the ABI sync rebuild on master shuffled Rollup chunks differently than the staging rebuild had, exposing the cycle for the first time.

Changes

  • `.github/workflows/{check-lint,test,check-build,codeql-analysis}.yml`: drop `staging` from the branch trigger lists.
  • `apps/{tangle-cloud,tangle-dapp,leaderboard}/netlify.toml`: update comments to reflect the new flow and the develop-as-staging deploy environment. The build ignore rule is unchanged — non-master branches already build, so develop branch deploys have always worked (verified at `https://develop--tangle-cloud.netlify.app\` / `-dapp` / `-leaderboard` returning 200).
  • `CLAUDE.md`: rewrite the Branch Strategy section to document the two-branch model, the `[RELEASE]` auto-sync convention, and the staging-deploy URL pattern.

Out-of-band follow-up (separate ops PRs / API calls)

  • Delete the `staging` branch on origin once this lands.
  • Drop `staging` from GitHub branch protection rules.
  • (Optional) Add Netlify domain aliases for `staging.{cloud,app,leaderboard}.tangle.tools` so the staging URLs are stable across deploys.

The `staging` branch has been vestigial for some time:
`auto-sync-master-with-develop.yml` already promotes develop to master
on every `[RELEASE]`-tagged commit, so the develop → staging → master
hop only added merge artifacts (see recent history: a725b00, cff4de8,
81bac41, c46c77a — all post-merge cleanups). The latest production
incident (cloud.tangle.tools forwardRef crash) was triggered by exactly
this kind of staging-merge rebuild surfacing a latent chunk-cycle bug.

Changes:
- `.github/workflows/{check-lint,test,check-build,codeql-analysis}.yml`:
  drop `staging` from the branch trigger lists.
- `apps/{tangle-cloud,tangle-dapp,leaderboard}/netlify.toml`: update
  comments to reflect the new flow and the develop-as-staging deploy
  environment. The build ignore rule is unchanged — non-master branches
  already build, so develop branch deploys have always worked.
- `CLAUDE.md`: rewrite the Branch Strategy section to document the
  two-branch model, the `[RELEASE]` auto-sync convention, and the
  staging-deploy URL pattern.

Out-of-band follow-up (will happen as separate ops PRs / API calls):
- Delete the `staging` branch on origin once this lands.
- Drop `staging` from GitHub branch protection rules.
- (Optional) Add Netlify domain aliases for staging.*.tangle.tools so
  the staging URLs are stable across deploys.
@drewstone drewstone requested a review from AtelyPham as a code owner May 14, 2026 11:03
@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit ed99353
🔍 Latest deploy log https://app.netlify.com/projects/tangle-cloud/deploys/6a05ac0cc5926b00087ec2ef
😎 Deploy Preview https://deploy-preview-3208--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit ed99353
🔍 Latest deploy log https://app.netlify.com/projects/tangle-dapp/deploys/6a05ac0ccf87e100083394e3
😎 Deploy Preview https://deploy-preview-3208--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026

Deploy Preview for tangle-leaderboard ready!

Name Link
🔨 Latest commit ed99353
🔍 Latest deploy log https://app.netlify.com/projects/tangle-leaderboard/deploys/6a05ac0ccf87e100083394e8
😎 Deploy Preview https://deploy-preview-3208--tangle-leaderboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@drewstone drewstone merged commit 2c93884 into develop May 14, 2026
17 of 19 checks passed
@drewstone drewstone deleted the chore/retire-staging-branch branch May 14, 2026 11:05
drewstone added a commit that referenced this pull request May 14, 2026
… to master

Promotes:
- #3204 fix(vite): merge @radix-ui into react chunk to break load-order cycle
- #3206 feat(tangle-cloud): wire dispute-bond claim flow (v0.15.0)
- #3208 chore: retire `staging` branch, document develop → master flow

This is the first non-cascade release after retiring the staging branch.
From this point forward, every `[RELEASE]`-tagged commit on develop
auto-promotes to master via auto-sync-master-with-develop.yml.
drewstone added a commit that referenced this pull request May 14, 2026
Folds in develop's three post-cascade commits:
- e404bb7 [RELEASE] Promote two-branch model retirement + dispute-bond claim UI to master
- 2c93884 Merge pull request #3208 from tangle-network/chore/retire-staging-branch
- ed99353 chore: retire `staging` branch, document develop → master flow

After this commit, master == develop, so the auto-sync-master-with-develop
workflow can fast-forward future `[RELEASE]`-tagged develop tips onto
master without divergence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant