Skip to content

fix(release): restore npm publish credentials #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewstone merged 1 commit into from
Sep 2, 2026
Merged

fix(release): restore npm publish credentials #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ jobs:
- name: Publish to npm
if: steps.npm-version.outputs.exists != 'true'
run: npm publish --access public --ignore-scripts
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_CONFIG_PROVENANCE: 'true'
- name: Create GitHub release
env:
GH_TOKEN: ${{ github.token }}
Expand Down
5 changes: 3 additions & 2 deletions tests/publish-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@ describe('release runtime contract', () => {
expect(ci).toContain('node-version: [24.18.0, 22.13.0]')
})

it('publishes through npm trusted publishing without a write token', () => {
it('publishes with the repository token and provenance', () => {
expect(publish).toContain('id-token: write')
expect(publish).toContain('node-version: 24.18.0')
expect(publish).toContain('registry-url: https://registry.npmjs.org')
expect(publish).toContain('package-manager-cache: false')
expect(publish).toContain('npm publish --access public --ignore-scripts')
expect(publish).not.toContain('NODE_AUTH_TOKEN')
expect(publish).toContain('NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}')
expect(publish).toContain("NPM_CONFIG_PROVENANCE: 'true'")
expect(publish).not.toContain('pnpm publish')
})
})