Skip to content

old: Texture dots#33

Open
patriciogonzalezvivo wants to merge 8 commits into
gh-pagesfrom
turbo_dots
Open

old: Texture dots#33
patriciogonzalezvivo wants to merge 8 commits into
gh-pagesfrom
turbo_dots

Conversation

@patriciogonzalezvivo

Copy link
Copy Markdown
Contributor

Adding a sdf-shape that could be reused for other styles. How it works?

  • takes a SDF texture u_sdf
  • which can be transform into a fill or stroke shape
  • I replace the previous circle function with it

We now can do more complex patterns if we want : )

@bcamper

bcamper commented Dec 14, 2016

Copy link
Copy Markdown
Member

Notes from discussion with @patriciogonzalezvivo:

  • Use a smaller dot texture, this one is quite big (78k), and I doubt the resolution is needed
  • Let's not include non-production files like the shader used to generate the dot. It's useful to save, but my goal is to have the bundler just be zip (e.g. not require any special bundling script that has to fetch additional files or exclude others).

@matteblair

Copy link
Copy Markdown
Member

You could put the 'brick' tiling pattern into the SDF texture as well, to further simplify the shader!

@patriciogonzalezvivo

Copy link
Copy Markdown
Contributor Author

Yes @blair1618 ! that's next on my TODO... I will wait for this PR to merge so I don't introduce a lot of changes at once. cc @nvkelso @bcamper @sensescape

@patriciogonzalezvivo

Copy link
Copy Markdown
Contributor Author

@nvkelso @bcamper can we merge this?

…s before refactor

tiny-dots are not showing up, force them to be medium in the mean time
@nvkelso

nvkelso commented Dec 28, 2016

Copy link
Copy Markdown
Member

@patriciogonzalezvivo can you help @sensescape and I debug why tiny-dots: don't show up at all? This is affecting landuse styles like cemetery and garden. We've set them to medium-dots in the meantime.

@patriciogonzalezvivo

Copy link
Copy Markdown
Contributor Author

hi @nvkelso, not sure what you need. seams like an old PR that wasn't merge

@nvkelso nvkelso changed the title Texture dots old: Texture dots Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants