fix(postgresql): support string concatenation in LIKE/regex right-hand side#2663
Open
nguyenmp wants to merge 1 commit into
Open
fix(postgresql): support string concatenation in LIKE/regex right-hand side#2663nguyenmp wants to merge 1 commit into
nguyenmp wants to merge 1 commit into
Conversation
…d side The right-hand side of LIKE and regex operators used the ordered choice (literal / comparison_expr), so a leading literal matched and committed before the `||` concatenation chain could be parsed, e.g. `col LIKE '%' || 'x' || '%'` failed with "but '|' found". Reorder the choice to (additive_expr / literal / comparison_expr) so the full expression (which handles `||`) is attempted first. Add round-trip tests for LIKE/NOT LIKE/ESCAPE and regex concatenation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
SELECT * FROM Users WHERE email ILIKE '%' || '@example.comThe right-hand side of LIKE and regex operators used the ordered choice (literal / comparison_expr), so a leading literal matched and committed before the
||concatenation chain could be parsed, e.g.col LIKE '%' || 'x' || '%'failed with "but '|' found".Reorder the choice to (additive_expr / literal / comparison_expr) so the full expression (which handles
||) is attempted first. Add round-trip tests for LIKE/NOT LIKE/ESCAPE and regex concatenation.