Add Boolean predicate pushdown support (cherry-pick)#7
Open
LLDay wants to merge 1 commit intodf-42-release-bindingfrom
Open
Add Boolean predicate pushdown support (cherry-pick)#7LLDay wants to merge 1 commit intodf-42-release-bindingfrom
LLDay wants to merge 1 commit intodf-42-release-bindingfrom
Conversation
This commit adds comprehensive support for pushing down Boolean predicates to the Iceberg table scan layer, improving query performance by filtering data at the storage level. Changes: - Enhanced expr_to_predicate.rs to handle boolean column expressions: * Bare boolean columns in filters (e.g., WHERE is_active) are converted to column = true predicates * NOT of boolean columns (e.g., WHERE NOT is_active) are converted to column = false predicates * Added Boolean scalar value to Datum conversion with: * Tests for is_active = true/false with EXPLAIN verification * Tests for is_active != true with EXPLAIN verification * Tests for combined predicates (AND/OR) * Tests for IS NULL/IS NOT NULL on boolean columns - Created test_boolean_table in engine setup for testing - Updated test schedule and show_tables baseline All tests verify that predicates are successfully pushed down to IcebergTableScan, not just executed in FilterExec. --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cheery pick of a commit that fixes a problem with boolean predicates.
See pull request 2082 in
apache/icebergfor more details.