Skip to content

Add truncate method support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palage4a merged 1 commit into from
Jul 24, 2025
Merged

Add truncate method support #78

palage4a merged 1 commit into from
Jul 24, 2025

Conversation

@Luccuo
Copy link

@Luccuo Luccuo commented May 26, 2025

No description provided.

@Luccuo
Copy link
Author

Luccuo commented May 26, 2025

Added tube_truncate method to clear tube

@Luccuo Luccuo force-pushed the sharded-queue-clear branch from b76a7dc to aca1d1e Compare May 26, 2025 12:47
@Luccuo Luccuo force-pushed the sharded-queue-clear branch from aca1d1e to f0c4049 Compare May 27, 2025 07:25
palage4a
palage4a requested changes Jun 6, 2025
View reviewed changes
Copy link
Collaborator

@palage4a palage4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Method truncate seems to me very 'infrastructure`-like, not for producation usage.
Can you provide some use cases into PR description?

Also, api methods should be tested. You can add an integration test in simple_test.lua.

@Luccuo Luccuo force-pushed the sharded-queue-clear branch from f0c4049 to 98c0e09 Compare June 11, 2025 12:15
@Luccuo Luccuo force-pushed the sharded-queue-clear branch 2 times, most recently from 2bc2bea to 35f44c6 Compare June 26, 2025 15:53
@tecl1s tecl1s requested a review from palage4a June 30, 2025 11:28
@palage4a
Copy link
Collaborator

palage4a commented Jul 2, 2025

@Luccuo rebase your branch on master for fixing CI/CD, please.

@Luccuo Luccuo force-pushed the sharded-queue-clear branch from 35f44c6 to 5f5a1a6 Compare July 4, 2025 12:58
palage4a
palage4a approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@palage4a palage4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

palage4a
palage4a requested changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@palage4a palage4a left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failed: https://github.com/tarantool/sharded-queue/actions/runs/16074336667/job/45535555077?pr=78

Fix them, please.

oleg-jukovec
oleg-jukovec requested changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch. Please fix red tests.

oleg-jukovec
oleg-jukovec requested changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to make sure that the metrics for the call are working.

Please, add a test for the truncate method:
https://github.com/tarantool/sharded-queue/blob/master/test/metrics_test.lua

@Luccuo
Copy link
Author

Luccuo commented Jul 15, 2025

@oleg-jukovec what metrics do you want to check? truncate metrics are checked in simple_test

@oleg-jukovec
Copy link
Contributor

oleg-jukovec commented Jul 15, 2025 •
edited
Loading

@oleg-jukovec what metrics do you want to check? truncate metrics are checked in simple_test

You checked the queue.statistics result, but not the truncate call count metric.

@Luccuo Luccuo force-pushed the sharded-queue-clear branch from 5f5a1a6 to 33636a8 Compare July 22, 2025 08:38
Add truncate method support
415ebc5 
The tube_truncate method was created to clean tubes, as well as the truncate method on the router to call it
@Luccuo Luccuo force-pushed the sharded-queue-clear branch from 33636a8 to 415ebc5 Compare July 22, 2025 14:46
palage4a
palage4a approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@palage4a palage4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@palage4a palage4a requested a review from oleg-jukovec July 23, 2025 15:15
oleg-jukovec
oleg-jukovec approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

@palage4a palage4a merged commit 850c9b7 into tarantool:master Jul 24, 2025
4 checks passed
palage4a added a commit that referenced this pull request Jul 28, 2025
@palage4a
changelog: add the entry about truncate() method.
6fdbf8e 
Follow-up for #78
palage4a added a commit that referenced this pull request Jul 28, 2025
@palage4a
lint: add trailing new line
3ad7225 
Follow-up for #78
palage4a added a commit that referenced this pull request Jul 28, 2025
@palage4a
doc: add truncate method in metrics description
b8843f0 
Follow-up for #78
@palage4a palage4a mentioned this pull request Jul 28, 2025
Merged
palage4a added a commit that referenced this pull request Aug 5, 2025
@palage4a
changelog: add the entry about truncate() method.
a063ece 
Follow-up for #78
palage4a added a commit that referenced this pull request Aug 5, 2025
@palage4a
lint: add trailing new line
c53a6cd 
Follow-up for #78
palage4a added a commit that referenced this pull request Aug 5, 2025
@palage4a
doc: add truncate method in metrics description
27702fd 
Follow-up for #78
palage4a added a commit that referenced this pull request Aug 6, 2025
@palage4a
doc: add the truncate() method changelog entry
fb76c52 
Follow-up for #78
palage4a added a commit that referenced this pull request Aug 6, 2025
@palage4a
lint: add trailing new line
6673809 
Follow-up for #78
palage4a added a commit that referenced this pull request Aug 6, 2025
@palage4a
doc: add truncate method in metrics description
c0bd390 
Follow-up for #78
palage4a added a commit that referenced this pull request Aug 6, 2025
@palage4a
doc: add the truncate() method changelog entry
56d5f7c 
Follow-up for #78
palage4a added a commit that referenced this pull request Aug 6, 2025
@palage4a
lint: add trailing new line
f17d0b5 
Follow-up for #78
palage4a added a commit that referenced this pull request Aug 6, 2025
@palage4a
doc: add truncate method in metrics description
bd04ae3 
Follow-up for #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

@palage4a palage4a palage4a approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Luccuo @palage4a @oleg-jukovec