fix(resolve-env): inline the env mapping so the reusable workflow works cross-repo - #118
Merged
Merged
Conversation
…ks cross-repo resolve-env.yml checked out the caller's repo and then ran ./actions/branch-env-map, a path that only exists in voidflow's own repo, so every caller failed at that step (found rolling it into taraxvoid.net). Inline the identical mapping instead; a test keeps it byte-identical to the composite action and covers the ref/event cases in both modes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
Validated on a real runner via taraxvoid.net#20 pointed at this branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve-env.ymldoesactions/checkout(which checks out the caller's repo) and thenuses: ./actions/branch-env-map, a path that only exists in voidflow's own repo. Every cross-repo caller therefore fails at that step with the action not found. Found rolling resolve-env into taraxvoid.net (resolve-env / Resolve env: Run ./actions/branch-env-mapfailed on the PR run).Fix: inline the mapping in the workflow (no checkout, no local action). A reusable workflow has no way to reference its own repo's composite action at a matching ref, so the script is duplicated;
test/branch-env-map.test.tsasserts the two scripts are byte-identical and runs the mapping for every ref/event case in both modes (defaultmain/next/livetodev/staging/prod, andsingle-environment), against both copies. Also asserts the workflow has nousessteps, so this cannot regress.Validating on a real runner via taraxvoid.net#20 pointed at this branch; result to follow here.
🤖 Generated with Claude Code