Repository navigation
fix(release): check the tag against the branch tip, not the run's checkout - #141
Merged
Merged
Conversation
…ckout release-please tags the branch as it is when it runs. When the 0.12.2 release PR merged while #130's run was in flight, that run created v0.12.2 on the release commit, but the publish job compared it to HEAD (#130's own commit), so it refused to publish. The release PR's own run then found the release already created and skipped publishing, so 0.12.2 never reached npm. Check ancestry against origin/<branch> instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
taraxvoid
pushed a commit
that referenced
this pull request
Oct 12, 2026
🤖 I have created a release *beep* *boop* --- ## [0.12.4](v0.12.3...v0.12.4) (2026-10-12) ### Bug Fixes * make the @playwright/test peer optional ([#142](#142)) ([a40fe21](a40fe21)) * **release:** check the tag against the branch tip, not the run's checkout ([#141](#141)) ([9dad79b](9dad79b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: ravenflight-releases[bot] <330165707+ravenflight-releases[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why 0.12.2 never reached npm:
release_created=true.git merge-base --is-ancestor v0.12.2 HEAD, but HEAD was the run's own checkout (f84a0f6), so it failed with "Tag v0.12.2 is not on branch main".release_createdwas false and publish was skipped.Fix: compare the tag against
refs/remotes/origin/<branch>, which the job'sfetch-depth: 0checkout fetches after release-please has finished. This keeps the same guarantee (the tag is on this channel's branch) and works no matter which push's run creates the release.0.12.3 replaced 0.12.2 on npm, so I'm not republishing 0.12.2.
🤖 Generated with Claude Code