Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,8 @@ jobs:
# Stable releases only: bring the release's version bump and changelog from
# main into next so the branches do not drift. Only version bookkeeping files
# may conflict and scripts/back-merge.ts resolves those; anything else fails
# the job loudly so a person resolves it (see RELEASING.md). The PR must be
# merged with a merge commit, not squashed.
# the job loudly so a person resolves it (see RELEASING.md). The PR is set to
# auto-merge with a merge commit, never a squash, so the branches share history.
back-merge:
name: Open main to next back-merge PR
needs: [channel, release-please]
Expand Down Expand Up @@ -347,6 +347,11 @@ jobs:
else
gh pr create --repo "$GITHUB_REPOSITORY" --base next --head "$BRANCH" \
--title "chore: back-merge ${TAG} into next" \
--body "Brings the ${TAG} version bump and changelog from main into next. Merge with a merge commit, not a squash, so the branches share history."
--body "Brings the ${TAG} version bump and changelog from main into next. Auto-merges with a merge commit once checks pass; do not squash it, or main's commits never become ancestors of next and the next back-merge conflicts on the same lines again."
fi

# The next ruleset allows squash for feature PRs, so a person clicking
# merge here would default to squash (v0.12.0 to v0.12.4 all were).
# Auto-merge pins the method to a real merge commit.
gh pr merge "$BRANCH" --repo "$GITHUB_REPOSITORY" --auto --merge

5 changes: 4 additions & 1 deletion RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ gitGraph
3. release-please opens or updates the stable release PR on `main`. Merging it
publishes under `latest`, moves the floating `v0` tag, and opens a
`main` to `next` back-merge PR.
4. Merge the back-merge PR with a merge commit too.
4. The back-merge PR auto-merges with a merge commit once checks pass. If you
ever merge one by hand (e.g. after resolving conflicts), use a merge commit,
never squash: a squash leaves main's commits out of next's history, so the
following back-merge conflicts on the same lines again.

## Hotfix

Expand Down
3 changes: 3 additions & 0 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading