Add JWT authentication options, and Expo instructions#155
Open
ericadamski wants to merge 3 commits intotaskrabbit:mainfrom
Open
Add JWT authentication options, and Expo instructions#155ericadamski wants to merge 3 commits intotaskrabbit:mainfrom
ericadamski wants to merge 3 commits intotaskrabbit:mainfrom
Conversation
ericadamski
commented
Sep 27, 2023
ericadamski
commented
Sep 27, 2023
fbartho
reviewed
Jan 30, 2025
Contributor
There was a problem hiding this comment.
0 functional changes to package.json, but changes to yarn.lock? This is a bit weird.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
Hope this contribution is helpful in adding JWT auth to the repo. This is my first time every writing ObjectiveC and first time writing Java for Android so any feedback is greatly appreciated!
Also Added some brief instructions on utilizing this package with Expo and Android since there is an extra step required.
Completely open to feedback and getting this in quickly as we are currently using a git submodule to build our app.
Thanks for the package! Integration was extremely simple.