Restore support for Felicita Arc scale and fix related bugs#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Felicita Arc support had been dropped due to occasional changing display modes on connect.
Root cause
The Acaia
IDENTIFY/heartbeat handshake was sent to every scale. The Felicitaparses each received byte as a command, and
IDENTIFYcontains0x31..0x35—its mode-select keys — so every (re)connect was switching the scale's mode.
Changes
FELICITAscale type instead of relying onGENERIC.sizeof().Testing
Disconnected/reconnected the ESP repeatedly, watching the scale's mode and the
UART output:
The forced weight+timer mode on init is now redundant and can be removed.
Not yet tested
only connect/init were tested on Felicita scales — shotStopper brew-by-weight operation needs testing ( I don't own a supported espresso machine).
Other scales (Acaia old/new, BooKoo/generic) need re-testing for connectivity
and operation.
I kept LIBRARY_VERSION same with added note as am not sure how you handle version control in this project.