Refactor services, enhance tests, and integrate error tracking#20
Merged
Conversation
- Deleted IExpressionService interface and its implementation. - Updated RuntimeChapterSaveServiceTests and ChapterExportServiceTests to remove dependencies on ExpressionService. - Added UVa-12803 input/output fixtures for expression evaluation. - Removed ExpressionServiceTests and integrated Lua expression evaluation tests. - Enhanced LuaExpressionScriptServiceTests to cover arithmetic and math library functions.
- Deleted phase review documents for core domain, infrastructure, viewmodels, views, scripts, localization, and cross-cutting analysis. - Removed the summary document detailing the overall code review findings and verdicts.
- Updated existing tests to reflect changes in the chapter import and export structure, ensuring compatibility with the new models.
- Refactored tests across multiple files to replace usage of `Time` with `StartTime` and `End` with `EndTime` for chapter objects. - Updated assertions in tests to reflect the new property names. - Introduced a new model `ReferencedMediaFile` to describe media files referenced by imported chapter sets.
- Added ChapterDiagnosticCode, ChapterDiagnosticSource, and ChapterDiagnosticReason to provide a structured way to represent diagnostic information. - Updated various test files to utilize the new ChapterDiagnosticCode for consistency and clarity in diagnostics. - Refactored existing diagnostic checks in tests to replace string literals with the new structured diagnostic codes. - Removed deprecated tests related to corrupt settings loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.