Use Number.p.toExponential for finite string values, Number for non-finite values#86
Merged
jessealama merged 3 commits intomainfrom Apr 23, 2026
Merged
Use Number.p.toExponential for finite string values, Number for non-finite values#86jessealama merged 3 commits intomainfrom
jessealama merged 3 commits intomainfrom
Conversation
|
gibson042
approved these changes
Feb 27, 2026
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
jessealama
force-pushed
the
explicit-value
branch
from
7383495 to
b4d3e2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be be beneficial if the representation of an Amount's string value was well definied, and if it unambiguously retained its precision.
Furthermore, the changes in #81 now allow us to use other types than strings to represent values, which would be useful for non-finite values.
So let's use the same representation that we're already emitting from Number.p.toExponential for finite values, and Number for the non-finite ones (
Infinity,-Infinity,NaN).