Excluding "immutable" from TA tests with mutable expectations.#5063
Open
iamstolis wants to merge 1 commit into
Open
Excluding "immutable" from TA tests with mutable expectations.#5063iamstolis wants to merge 1 commit into
iamstolis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables the usage of immutable
ArrayBuffers inTypedArray-related tests that have "mutable" expectations:TypedArray/prototype/slice/speciesctor-return-same-buffer-with-offset.js: expects slice to copy into a species-created result backed by the same buffer. With an immutable buffer, the species-created result is not a valid write target, so slice throws instead of producing the mutable-copy result.TypedArrayConstructors/internals/GetOwnProperty/index-prop-desc.js,TypedArrayConstructors/internals/GetOwnProperty/BigInt/index-prop-desc.js: expect indexed property descriptors to be writable and configurable. For immutable-backed TypedArrays, indexed properties are not writable/configurable.TypedArrayConstructors/internals/Set/bigint-tonumber.js,TypedArrayConstructors/internals/Set/BigInt/null-tobigint.js,TypedArrayConstructors/internals/Set/BigInt/number-tobigint.js,TypedArrayConstructors/internals/Set/BigInt/string-nan-tobigint.js,TypedArrayConstructors/internals/Set/BigInt/symbol-tobigint.js,TypedArrayConstructors/internals/Set/BigInt/tonumber-value-throws.js,TypedArrayConstructors/internals/Set/BigInt/undefined-tobigint.js,TypedArrayConstructors/internals/Set/tonumber-value-throws.js: validate value-conversion abrupt completions during indexed assignment, such asToNumber,ToBigInt, or user-defined coercion hooks throwing. For immutable-backedTypedArrays, indexed[[Set]]short-circuits before value conversion, so those mutable-buffer conversion expectations do not apply.