fix: Custom reader should read till endblock#61
Open
svaningelgem wants to merge 4 commits intotcalmant:masterfrom
Open
fix: Custom reader should read till endblock#61svaningelgem wants to merge 4 commits intotcalmant:masterfrom
svaningelgem wants to merge 4 commits intotcalmant:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it a recursive loop while sticking to the current code as close as possible.
All tests pass without any change, and my new test works now too. (didn't work with the old code).
(afterwards I realized this is only an issue under v1, not v2. so I moved the test to v1)