[sync] T4086 Avoid computed updates through unavailable tables T4086#3219
[sync] T4086 Avoid computed updates through unavailable tables T4086#3219tea-artist wants to merge 1 commit into
Conversation
Synced from teableio/teable-ee@99a5c55 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky-Teable <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef3554d956
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ((await this.cacheService.get(key)) === this.owner) { | ||
| await this.cacheService.del(key); |
There was a problem hiding this comment.
Release Redis lock atomically with owner check
The get + del sequence is not atomic, so a lock can be deleted after ownership changes: if this process reads its own owner value, then the key expires and another instance acquires it before del runs, the subsequent del removes the new owner’s lock. That breaks mutual exclusion and can allow overlapping critical sections when tasks run near TTL boundaries. Use an atomic compare-and-delete (e.g., a Lua script) instead of separate calls.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
🔄 Automated sync from EE repository.
49 commit(s) synced since last sync.
Authors
Included commits
Latest source commit: teableio/teable-ee@99a5c55
This PR was automatically created by the sync workflow.