fix(unkee): 404 on /unkee/sync-confirmed after Cloud Sync sign-in - #52
Merged
Merged
Conversation
The sync backend (routes/auth.ts) redirects mobile clients here after a magic-link sign-in is approved, but no page existed at this path and it was never registered in the AASA (apple-app-site-association) component list — so on iOS the link never even qualified as a universal link, it always fell through to Safari and 404'd there, regardless of whether the app was installed. Adds a static SvelteKit page at /unkee/sync-confirmed acting as a sensible fallback (works with or without the app installed), and adds the path to the AASA component list so the main UnKee app intercepts it as a universal link when installed. Android already covers this: its manifest verifies the whole techquests.dev/unkee/* prefix rather than enumerating paths. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…n-in Adds the Authenticator counterpart to /unkee/sync-confirmed: a /authenticator/sync-confirmed page plus its own AASA entry (293M4MWUJC.dev.techquests.unkeeauth), so Authenticator's Cloud Sync sign-in hands back to the right app/branding instead of falling through to UnKee's. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
Both were failing CI's lint-and-test job on formatting; fixes the pre-existing unkee page too since this branch already touches it. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync backend (routes/auth.ts) redirects mobile clients here after a
magic-link sign-in is approved, but no page existed at this path and it
was never registered in the AASA (apple-app-site-association) component
list — so on iOS the link never even qualified as a universal link, it
always fell through to Safari and 404'd there, regardless of whether the
app was installed.
Adds a static SvelteKit page at /unkee/sync-confirmed acting as a
sensible fallback (works with or without the app installed), and adds
the path to the AASA component list so the main UnKee app intercepts it
as a universal link when installed. Android already covers this: its
manifest verifies the whole techquests.dev/unkee/* prefix rather than
enumerating paths.
Signed-off-by: Andre Nogueira aanogueira@protonmail.com