Skip to content

Fix padding and margin CSS property handling#847

Open
oges-asset067 wants to merge 1 commit intotecnickcom:mainfrom
oges-asset067:patch-1
Open

Fix padding and margin CSS property handling#847
oges-asset067 wants to merge 1 commit intotecnickcom:mainfrom
oges-asset067:patch-1

Conversation

@oges-asset067
Copy link
Copy Markdown

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@williamdes
Copy link
Copy Markdown
Contributor

Please provide an example code to trigger the bug
Before and after pdfs can help too
See the examples/ folder

@nicolaasuni
Copy link
Copy Markdown
Member

Thank you very much, @oges-asset067, for the CSS padding and margin fix - it is genuinely appreciated.

TCPDF 6 is now deprecated and no further changes will be merged into this repository. Please see the pinned issue Thank You - and the Future of TCPDF for the full explanation and the path forward.

CSS layout handling has been substantially redesigned in tc-lib-pdf. If you are able to reproduce the padding or margin issue there, feel free to open a PR or issue in that repository. If you need any help adapting your fix to the new library, please open a discussion and I will do my best to assist.

I am leaving this PR open in case you or anyone else wishes to continue the discussion, but it is unlikely that this PR will ever be merged.

Thank you again for your patience and understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants