feat: add ability to set per-request requestTimeout#1530
Draft
dhensby wants to merge 1 commit intotediousjs:masterfrom
Draft
feat: add ability to set per-request requestTimeout#1530dhensby wants to merge 1 commit intotediousjs:masterfrom
dhensby wants to merge 1 commit intotediousjs:masterfrom
Conversation
parth2326
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does:
This adds an optional config object that can be passed to
Request,TransactionandPreparedStatementobjects to provide one-off/per-instance overrides for config settings on the pool. At the moment that is purely forrequestTimeout, but does provide the foundation to add other options too.Things to think about:
Transactionclasses accept this option given that it is non-trivial in tedious to actually set the timeout on the begin/end/commit transaction queries (because tedious creates their own request without exposing it when starting/commiting transactions)? If we don't we end up with a bit of a mis-matched API and perhaps we should add it, but it is then applied to a transactions requests unless overridden again...Still to do:
Related issues:
Closes #1529
Pre/Post merge checklist: