feat: ability to provide specific config.driver for msnodesqlv8#1799
feat: ability to provide specific config.driver for msnodesqlv8#1799dhensby merged 1 commit intotediousjs:masterfrom
Conversation
|
@dhensby let me know if you are ok with this feature In CI - before running mssql with msnodesqlv8, I run a script that patches this package to use the "ODBC Driver 18 for SQL Server" driver |
|
Thanks @alexsch01 - my main concern now is that this doesn't have any test coverage, so there's no regression detection for the futue. Would you be able to add a test to show that we can update the config with a different driver and it still works? |
|
@dhensby I added a test, can you let the checks run? |
|
The last 2 commits will fail commit linting - they can be squashed into the first commit |
|
@dhensby hey can you let checks run? |
simplify tests for config.driver revert partially of the test change Update msnodesqlv8.js revert workflow change change test for Windows Update msnodesqlv8.js fix: msnodesqlv8 test
|
one more time, sorry @dhensby |
|
All tests passed! @dhensby |
|
Thanks so much for the work on this and putting up with the tedium of the commit conventions! |
no problem, glad the issue this PR fixes is resolved |
|
🎉 This PR is included in version 12.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Being able to override CONNECTION_DRIVER (now DEFAULT_CONNECTION_DRIVER) variable for mssql/msnodesqlv8
Changed README, don't know if GitHub Pages site needs an update