Skip to content

Call new ConnectionError with appropriate args#1811

Open
gavinaiken wants to merge 1 commit intotediousjs:masterfrom
gavinaiken:master
Open

Call new ConnectionError with appropriate args#1811
gavinaiken wants to merge 1 commit intotediousjs:masterfrom
gavinaiken:master

Conversation

@gavinaiken
Copy link

What this does:

Calls new ConnectionError with the appropriate args

Before:

conn err: ConnectionError: [object Object]
    at PrivateConnection.callback2 (/Users/gavin/repos/node-core/collector/collector-server/node_modules/mssql/lib/msnodesqlv8/connection-pool.js:47:17)
    at Immediate._onImmediate (/Users/gavin/repos/node-core/collector/collector-server/node_modules/msnodesqlv8/lib/connection.js:47:14)
    at process.processImmediate (node:internal/timers:485:21) {
  code: undefined
}

After:

conn err: ConnectionError: [unixODBC][Driver Manager]Can't open lib 'ODBC Driver 17 for SQL Server' : file not found
    at PrivateConnection.callback2 (/Users/gavin/repos/node-core/collector/collector-server/node_modules/mssql/lib/msnodesqlv8/connection-pool.js:47:17)
    at Immediate._onImmediate (/Users/gavin/repos/node-core/collector/collector-server/node_modules/msnodesqlv8/lib/connection.js:47:14)
    at process.processImmediate (node:internal/timers:485:21) {
  code: 0
}

Related issues:

Resolves #1810

Pre/Post merge checklist:

  • Update change log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors in ConnectionError open do not provide details

1 participant