Add common NGSI-LD constants#897
Merged
Merged
Conversation
Add GeoProperty, Point , Date and Time types since GeoJSON is native in NGSI-LD
Contributor
Author
|
Note that it should be discussed if further additions should be required for |
fgalan
reviewed
Sep 8, 2020
Comment on lines
-40
to
-42
| case LOCATION_TYPE: | ||
| switch (type.toLowerCase()) { | ||
| case 'geoproperty': | ||
| return LOCATION_DEFAULT; | ||
| case DATETIME_TYPE: |
Member
There was a problem hiding this comment.
Is there any other usage of LOCATION_TYPE and DATETIME_TYPE (removed in this PR) appart of the ones in this point?
Contributor
Author
There was a problem hiding this comment.
Doesn't look like it, so those statements are now redundant and can be removed. Fixed 9d65c09
fgalan
approved these changes
Sep 8, 2020
Member
fgalan
left a comment
There was a problem hiding this comment.
LGTM
Shoud I merge? Or some other (with a better knowledge on NGSI-LD) should provide additional LGTM before that?
Contributor
Author
|
Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GeoProperty, Point , Date and Time types since GeoJSON is native in NGSI-LD.
NGSI-v2
The following provisioning statement is valid:
NGSI-LD
The following equivalent provisioning statement should be valid for NGSI-LD:
but currently fails since
GeoPropertyis not defined as an exception and the defaultstringvalue" "is not valid GeoJSON.