Claim NFT task print args#528
Merged
ethereumdegen merged 2 commits intoteller-protocol:developfrom Nov 7, 2025
Merged
Conversation
Improves performance of NFT viewing by batching `isClaimed` calls. Instead of checking claim status individually within a loop, this change gathers all claims and then executes the `isClaimed` checks in parallel, significantly reducing the overall processing time.
Adds a `printArgs` flag to the `claim-nft` task, enabling users to print function arguments and encoded calldata for inspection without executing the transaction. This enhances transparency and allows for manual verification of transaction details. Also updates dependencies and removes `.nvmrc` and engines from `package.json`.
passabilities
had a problem deploying
to
testing-keys
GitHub Actions
Failure
passabilities
had a problem deploying
to
testing-keys
GitHub Actions
Failure
Collaborator
|
The new code looks good to me. I was able to set up my local environment and run the task as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--print-argsflag toclaim-nfttask to use on Etherscanhh claim-nft --network mainnet --account 0x123 --print-argsview-nfttask to view un/claimed nfts