Feature/lender commitment groups#137
Open
ethereumdegen wants to merge 147 commits intofeature/optimize-market-registry-termsfrom
Open
Feature/lender commitment groups#137ethereumdegen wants to merge 147 commits intofeature/optimize-market-registry-termsfrom
ethereumdegen wants to merge 147 commits intofeature/optimize-market-registry-termsfrom
Conversation
ethereumdegen
changed the base branch from
develop
to
feature/optimize-market-registry-terms
Feature/lender commitment groups
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
ethereumdegen
commented
Nov 3, 2023
...s/LenderCommitmentForwarder/extensions/LenderCommitmentGroup/LenderCommitmentGroup_Smart.sol
Outdated
Show resolved
Hide resolved
...s/LenderCommitmentForwarder/extensions/LenderCommitmentGroup/LenderCommitmentGroup_Smart.sol
Show resolved
Hide resolved
|
|
||
| require(_liquidityThresholdPercent <= 10000, "invalid threshold"); | ||
|
|
||
| liquidityThresholdPercent = _liquidityThresholdPercent; |
Contributor
There was a problem hiding this comment.
we havent used this variable at all , do we still want to keep it?
Contributor
Author
There was a problem hiding this comment.
it is used in getPrincipalAmountAvailableToBorrow()
...s/LenderCommitmentForwarder/extensions/LenderCommitmentGroup/LenderCommitmentGroup_Smart.sol
Show resolved
Hide resolved
|
|
||
|
|
||
|
|
||
| function repayLoanCallback( |
Contributor
There was a problem hiding this comment.
is this callback happening when liquidations happen too ?
Contributor
Author
There was a problem hiding this comment.
no , see comment
…protocol/teller-protocol-v2 into feature/lender-commitment-groups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three contracts:
A LenderCommitmentGroupFactory which is able to deploy new LenderCommitmentGroup contracts.
LenderCommitmentGroup contract which allows lenders to pool their funds together for a single LCF commitment .
A SharesToken which is used for accounting to keep track of how much equity each lender has in a group.