Implement multi-namespace search attribute translation#96
Open
Implement multi-namespace search attribute translation#96
Conversation
pglass
commented
Jun 19, 2025
| type visitor func(obj any, match stringMatcher) (bool, error) | ||
| // currentNamespaceId is internal-state to remember the namespace id set in some parent | ||
| // field as the visitor descends recursively into child fields. | ||
| currentNamespaceId string |
Contributor
Author
There was a problem hiding this comment.
Switch to a Visitor struct so that we can track currentNamespaceId as we recursively descend into struct.
pglass
commented
Jun 19, 2025
Comment on lines
+151
to
+153
| nsId := discoverNamespaceId(vwp) | ||
| if nsId != "" { | ||
| v.currentNamespaceId = nsId |
Contributor
Author
There was a problem hiding this comment.
Check for and remember namespace id on each type as we descend.
pglass
commented
Jun 19, 2025
| v := MakeSearchAttributeVisitor(s.getNamespaceRespMatcher) | ||
| switch val := req.(type) { | ||
| case *adminservice.GetWorkflowExecutionRawHistoryV2Request: | ||
| v.currentNamespaceId = val.NamespaceId |
Contributor
Author
There was a problem hiding this comment.
Special handling for GetWorkflowExecutionRawHistoryV2Response. Carry over the namespace id found in the corresponding request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Implement search attribute translation for multiple namespaces.
Why?
Checklist
Closes
How was this tested:
Similar to steps in #93, but:
Create 2 replicated namespaces
In proxy-a, add namespace translation (optional)
In proxy-b configure the search attributes. To discover the search attribute mapping,
~/code/cli/temporal --address localhost:8233 operator namespace describe -n $NS --grpc-meta xdc-redirection=false -o jsonStart workers for both namespaces
Run workflows in both namespaces simultaneously
Run force replication in both namespaces
Test handover
Check that queries with search attributes work on the target cluster, and return same results as source