Skip to content

Fail the workflow task when the test server refuses a command instead of stranding it #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sangkyoonnam wants to merge 2 commits into
base: main
Choose a base branch
from
+907 −36
Open

Fail the workflow task when the test server refuses a command instead of stranding it #3097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6963ce2
Fail the workflow task when the test server refuses a command instead…
sangkyoonnam Sep 24, 2026
f206a60
Defer pre-commit effects and map update refusals in the test server
sangkyoonnam Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions temporal-test-server/src/main/java/io/temporal/internal/testservice/StateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,24 @@ <V> StateMachine<Data> add(
return this;
}

/** Number of transitions taken so far; pass it to {@link #rollbackTo(int)}. */
int transitionCount() {
return transitionHistory.size();
}

/**
* Undoes the transitions taken after {@code transitionCount} was read, restoring the state the
* machine had at that point. For when the request that caused those transitions is refused before
* its {@link RequestContext} is committed: the events the callbacks added are discarded with the
* context, and the in-memory state must not run ahead of history.
*/
void rollbackTo(int transitionCount) {
while (transitionHistory.size() > transitionCount) {
Transition undone = transitionHistory.remove(transitionHistory.size() - 1);
state = undone.from;
}
}

<R> void action(Action action, RequestContext context, R request, long referenceId) {
Transition transition = new Transition(state, action);
@SuppressWarnings("unchecked")
Expand Down
Loading
Loading