Improved static analysis for proxied workflows and activities#738
Open
mtorromeo wants to merge 1 commit intotemporalio:masterfrom
Open
Improved static analysis for proxied workflows and activities#738mtorromeo wants to merge 1 commit intotemporalio:masterfrom
mtorromeo wants to merge 1 commit intotemporalio:masterfrom
Conversation
|
@mtorromeo is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added multiple type parameters to stub/proxy classes, with templated ReturnType for workflow methods and UpdateHandle, and used @mixin instead of lying about the return type of proxy instances.
Why?
This fixes multiple type inference issues that I encountered when using this library. I am using PHPStan instead of psalm but every annotation involved is supported by both analyzers.
Checklist
I have been using a patched version with these changes for a few months in a project that is in production without any issues. This does not touch any actual php code anyway, just doc comments for the static analyzers.
Nothing needs to be updated.