docs: validate links in docs build#607
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 086adca9ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cleanPath.slice(1), | ||
| ); | ||
|
|
||
| if (await fileExists(absoluteRootPath)) return true; |
There was a problem hiding this comment.
Don't treat a path as valid just because access() succeeds on a repo directory. Here, internalTargetExists returns success for any absolute link whose path happens to match an existing folder (for example /scripts), even when there is no corresponding docs route or static file. That creates false negatives in the new validator and allows genuinely broken internal links to pass CI/build checks.
Useful? React with 👍 / 👎.
1 participant
Summary
pnpm build,pnpm check:ci, and a newpnpm check:linkscommandisowsand Tempo session reference links surfaced by the new checkTesting