Repository navigation
feat(notifications): localise push text and action buttons (#1037) - #1041
Merged
tempus2016 merged 3 commits intoOct 7, 2026
Merged
tempus2016 merged 3 commits into
tempus2016 merged 3 commits into
Conversation
Built-in notification messages, the Approve/Reject buttons, the reject reason placeholder and the "open the panel" hint now follow Home Assistant's language. Wording lives in www/locales under notify.* keys; English is baked in as the fallback for a missing locale, key, or a translation whose placeholders don't format. Also localises the caller-built auction result, weekly digest and monthly report lines. Translated into da, de, fr, nb, nn, pl, pt, pt-BR.
github-actions
Bot
added
backend
tempus2016
deleted the
feat/1037-localize-push-notification-text-and-action-buttons
branch
October 7, 2026 18:21
tempus2016
added a commit
that referenced
this pull request
Oct 7, 2026
Follow-up to #1041. Celebration messages, recap announcements (and their period labels), month and weekday names in the monthly report, season champion and auction dates, name lists ("A, B and C") and the panel's test-push sample names now follow HA's language too. Strings are loaded at startup and reloaded when HA's language changes, so text built outside the dispatcher is translated as well. A test push now fills {date}, {max_points}, {result_text} and {freezes_left}, which were previously sent as literal placeholders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
TaskMate's push notifications now follow Home Assistant's language (Settings → System → General), the same as the cards and panel.
What's localised
German example from the issue:
How
notify_strings.py: readsnotify.*keys fromwww/locales/<lang>.json(exact language, then its base, sode-CH→de), off the event loop, cached per language. English is baked in, so a missing locale, missing key or broken translation still produces a readable English message.message_templateis the user's own text and is left untouched.Not in this PR (follow-up)
Celebration messages, recap-ready messages, month names in the monthly report / season champion, and the auction date label are still English. They're built in several other places and feed bus events too, so they need their own change.
Tests
tests/test_notify_strings.py: en.json matches the baked-in English; every locale keeps exactly the English placeholders; German message + buttons end to end throughfire(); base-language and English fallbacks; a broken translation falls back to English; the panel hint is translated; custom templates untouched.