You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Sticker chart card and logging a job done on an earlier dayUpstream pr/sticker - #1063
Adds the Sticker Chart card (today's jobs as stickers to tap, stars filling towards a reward or this week's jobs) and lets a parent log a job done on an earlier day that nobody ticked: complete_chore takes completed_date (parent-only, last 7 days), and the admin panel has a "Log a past job" dialog per child that shows the chart for the chosen day.
Backdated completions go through the same recording and follow-up code as a parent ticking a job (_async_record_completion + _async_after_completions): badges, quests, challenges, last_completed and one-shot disabling all behave as for any approval. last_completed is only moved forward, never back behind a later completion, and undoing a backdated job leaves the streak alone.
Weekly-target chores can be logged on any day while that week's quota is open; open-ended, teamwork, rotation and auction-won chores are refused with a clear message. The weekly target bonus is settled for the week the job belongs to, and every-N-days chores only on their days. week_progress counts a weekly-target chore's quota once and gives open-ended chores no "available" total.
Panel dialog: waits for the card module before mounting it, and falls back to a plain job list (instead of throwing) if the card can't be built or the overview sensor is missing.
No sound or confetti for a past day; the day picker uses HA's time zone, not the browser clock.
Test files ruff-formatted.
Depends on the photo PR (#1062) — this branch is stacked on it, so it shows those two commits until that one lands.
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that changes existing behaviour)
Documentation only
CI / tooling / chore
How has this been tested?
Ran ruff check . locally (matches the Ruff CI check)
Ran pytest locally (matches the Run tests CI check)
Exercised the change on a live Home Assistant instance
For card changes: hard-refreshed the browser and checked the console for errors
ruff format --check and ruff check clean; pytest 3215 passed; npm test 653 passed; translation and data-file checks pass. New tests: tests/test_complete_chore_on_date.py (hooks, weekly-target/open-ended/teamwork/auction rules, weekly bonus, every-N-days, undo), tests/test_week_progress.py, tests/test_sticker_chart_card.py, and tests/frontend/taskmate-sticker-chart-backdate.test.cjs (panel guards, no sound or celebration on a past day, day picker in several time zones).
Live: on my HA (2026.9) the card is in daily use for two children. I used "Log a past job" from the panel for an earlier day: the dialog opened with that day's chart, ticking a job logged and paid it for that day, and undoing it took it back. That instance runs this change on top of 6.1.0; the branch here is rebased on current main, so the 6.2 weekly target bonus interaction is covered by tests only.
Checklist
My code follows the existing patterns in the codebase
I bumped manifest.jsonversion if this is a release-bound change
Any new user-facing strings are translated into all locales
(da, de, fr, nb, nn, pl, pt, pt-BR) in this same PR — not English-only
I updated the README / docs where relevant
I did not add Claude / AI co-author attribution to commits or files
Adds an optional per-child picture entity (normally the child's person.*).
Its picture is read on every update and exposed as avatar_image, and a
shared __taskmate_child_visual helper makes every card prefer the photo
and fall back to the MDI avatar. The panel's child dialog gets a
"Photo from" picker.
A child's photo is read from their picture entity, but the sensors' shared
context was cached per coordinator update, so a photo changed on the person
entity stayed stale until the next TaskMate refresh. Track each child's
picture entity and refresh the sensors when its picture really changes, and
make the shared cache aware of external entity changes.
Adds the taskmate-sticker-chart-card Lovelace card and an admin-panel
dialog for logging jobs done on an earlier day. Builds on the child photo
change for the children's faces.
Backdated completions run the same post-approval hooks as a normal
approval (badges, quests, challenges, last_completed, one-shot disabling),
account for weekly-target and open-ended chores, and are marked so undoing
one does not lower the streak.
…chores
A job logged for an earlier day settles that week's weekly target bonus
(tempus2016#1044), and an every-N-days chore (tempus2016#1038) can only be logged on one of
its days.
The photo change already adds panel.child_picture_entity_label and _hint;
this branch added them a second time, which check-json rejects as
duplicate keys.
The past-day sticker chart skipped the weekly-target cap, so after a
backdated tick filled the selected week's quota the tile still offered
another tap that TaskMate then refused, and a week other than the current
one could offer a tap on an already-full quota. The day lookup now also
returns that week's progress per child, and the card caps a past day with
it exactly as it caps today with weekly_chore_progress.
Backdated completions are allowed during vacation periods
custom_components/taskmate/coord_chores.py:1176
The date-schedule check does not account for configured vacation periods, although chores are hidden on those dates elsewhere and week_progress explicitly removes those days from the available total. A direct complete_chore call can therefore backdate and award a chore on a planned vacation day. Reject is_vacation_day(day) before the weekly-target/schedule checks.
Weekly denominator ignores teamwork point sharing and bonuses
custom_components/taskmate/coord_points.py:75
Teamwork completions award team_share_points (including split mode and team_bonus), but the weekly denominator uses the full base points. A 10-point, two-person split chore contributes 10 available points while each child can earn only 5; conversely a team bonus can make earned exceed available. Use the same per-participant point calculation as completion and sensor rendering.
…a day
Addresses the Copilot review on tempus2016#1063:
- A switched-off chore is refused even when it has a weekly target (that
path skipped the due-day check, which was where it used to be caught),
and a day inside a holiday is refused.
- The rules live in _backdate_refusal. The day lookup now also returns the
chores each child could have logged that day (loggable), so the plain
list and the past-day sticker chart follow every schedule TaskMate knows
(recurrences, every-N-days, calendar moves, holidays), not just weekdays.
The plain list also leaves out weekly-target chores whose quota that
week is full.
- A finished one-off job keeps its tile on the day it was ticked, so it can
still be undone.
- Reduced motion also stops the celebration bouncing and the confetti.
- Week progress counts a teamwork chore at each member's share plus any
team bonus, as it is paid.
Addresses the Copilot review on tempus2016#1062:
- The chore board, kiosk and recap cards now draw a child through the
shared face helper, so a child's photo shows there too and a child
without one keeps their avatar. (The badges card has no per-child avatar
to draw: its sensor sends none, so it always shows the generic icon.)
- The set of tracked picture entities trims each id the same way the photo
lookup reads it, so a stray space can't leave a photo untracked.
Addresses the second Copilot review on tempus2016#1062: the bounty board and auction
cards drew every child as an initial, and the child card's teamwork row
read the avatar directly. All three now use the shared face helper, so a
child's photo shows there; the bounty and auction cards keep the initial
for a child without one.
Backdating bypasses the existing birthday day-off rule: _is_chore_scheduled_for_date only evaluates the chore's calendar schedule, so a non-mandatory chore can be offered and logged on a child's birthday even when birthday_chores_off is enabled. Apply the same child-specific birthday exclusion used by the normal due/availability paths; mandatory chores should remain eligible.
Photo picker excludes non-person entities with pictures
The stacked photo change is described as supporting a person or any entity with a picture, and the backend resolver accepts any entity ID, but this picker restricts users to person.*. Since the custom picker filters out every other domain, the panel cannot configure the advertised non-person case. Remove the domain restriction or filter candidates by entity_picture instead.
…ty with a picture
Addresses the third Copilot review on tempus2016#1062:
- The badges sensor now says whose badges they are (child_name,
child_avatar, avatar_image), and the card draws that face through the
shared helper. Before, the sensor sent neither, so the card always
showed a generic icon.
- "Photo from" lists any entity that has a picture (person, image,
camera...) instead of person entities only, matching what the backend
accepts.
Addresses the latest Copilot review on tempus2016#1063:
- Undoing a completion refunded its weekly target bonus only inside the
streak block, which skips backdated jobs, so a backdated job's bonus
outlived the job. The refund now runs for every completion.
- A child's birthday with "chores off" is refused for every chore but the
mandatory ones, the same rule today's chore list follows.
Apply birthday rules consistently to weekly goal denominator
custom_components/taskmate/coord_points.py:88
The denominator does not apply the existing birthday rules. With birthday_chores_off, non-mandatory jobs on the child's birthday are counted even though they cannot be completed; when chores remain enabled, earned includes the birthday multiplier but available does not. This can make the weekly target either unreachable or fill early, so exclude birthday days off and apply the same multiplier as _award_points.
Provide keyboard-accessible undo for completed chores
Undo is exposed only through a pointer press-and-hold. Keyboard activation always calls _complete, which is a no-op for an already completed tile, so keyboard and switch-device users cannot perform the advertised undo action. Add a keyboard-accessible undo control or key binding and expose it in the accessible label/instructions.
The weekly goal's denominator now drops a child's non-mandatory chores on
their birthday day off and applies the birthday multiplier to that day,
matching what the chores would actually pay.
Delete/Backspace on a ticked tile undoes it, the keyboard twin of
press-and-hold, and the tile advertises it with aria-keyshortcuts.
TaskMate's child sensors show the photo chosen for the child, so picking
one as the source made the face refer to itself and go stale. The picker
no longer lists them and the backend ignores one if it was already saved.
The hint now says any entity with a picture can be used, the child's
person being the usual choice.
Thanks, this round covers everything I had. The weekly bonus now comes back off when a past-day job is undone, the birthday day off is respected (including in the weekly goal), and the sticker chart has keyboard undo. Nice to see tests for each of them.
This one waits on #1062, so it inherits the hint translation follow-up I left there. When that lands I'll test this on my dev instance and review it properly. It's a large change to points and streaks, so it may take me a little while.
Merged, thank you! Squash-merging #1062 left this branch with a small conflict in sensor.py (two neighbouring additions), and I can't push to your fork, so it went in through #1064. That's your branch with main merged in, giving a tree identical to this PR's head, and you're credited as co-author on the commit (e249237). I've also picked up the picker hint translations myself, so there's nothing left for you to do there. Closing this one as landed.
Merged, thank you! Squash-merging #1062 left this branch with a small conflict in sensor.py (two neighbouring additions), and I can't push to your fork, so it went in through #1064. That's your branch with main merged in, giving a tree identical to this PR's head, and you're credited as co-author on the commit (e249237). I've also picked up the picker hint translations myself, so there's nothing left for you to do there. Closing this one as landed
Great thank you and for the credit. Keep up the great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backendPython integration codecardsLovelace cards / frontend (www/*.js)documentationImprovements or additions to documentationtestsTest suitetranslationsi18n / locale strings
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
documentation
Summary
Adds the Sticker Chart card (today's jobs as stickers to tap, stars filling towards a reward or this week's jobs) and lets a parent log a job done on an earlier day that nobody ticked:
complete_choretakescompleted_date(parent-only, last 7 days), and the admin panel has a "Log a past job" dialog per child that shows the chart for the chosen day.Changes since #913, following your review:
_async_record_completion+_async_after_completions): badges, quests, challenges,last_completedand one-shot disabling all behave as for any approval.last_completedis only moved forward, never back behind a later completion, and undoing a backdated job leaves the streak alone.week_progresscounts a weekly-target chore's quota once and gives open-ended chores no "available" total.Depends on the photo PR (#1062) — this branch is stacked on it, so it shows those two commits until that one lands.
Related issue
N/A — follows #913.
Type of change
How has this been tested?
ruff check .locally (matches theRuffCI check)pytestlocally (matches theRun testsCI check)ruff format --checkandruff checkclean; pytest 3215 passed;npm test653 passed; translation and data-file checks pass. New tests:tests/test_complete_chore_on_date.py(hooks, weekly-target/open-ended/teamwork/auction rules, weekly bonus, every-N-days, undo),tests/test_week_progress.py,tests/test_sticker_chart_card.py, andtests/frontend/taskmate-sticker-chart-backdate.test.cjs(panel guards, no sound or celebration on a past day, day picker in several time zones).Live: on my HA (2026.9) the card is in daily use for two children. I used "Log a past job" from the panel for an earlier day: the dialog opened with that day's chart, ticking a job logged and paid it for that day, and undoing it took it back. That instance runs this change on top of 6.1.0; the branch here is rebased on current main, so the 6.2 weekly target bonus interaction is covered by tests only.
Checklist
manifest.jsonversionif this is a release-bound change(
da,de,fr,nb,nn,pl,pt,pt-BR) in this same PR — not English-onlyREADME/ docs where relevantVersion left for you to set at release.