Repository navigation
fix(cards): keep the sticker chart overflow count on one line (#1070) - #1072
Merged
Merged
Conversation
The sticker row uses word-break: break-all so emoji wrap tightly, and the overflow badge inherited it, so +10 could split into +1 and a stray 0 on the next line. The badge is now an unbreakable inline block.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1070
What was wrong
The sticker row on the Sticker Chart card uses
word-break: break-allso the emoji wrap tightly. The overflow count after the last sticker (for example+10) inherited it, so it could split across lines:+1at the end of the row and a stray0on the line below.Fix
.overflowis nowdisplay: inline-block; white-space: nowrap; word-break: normal. The count still wraps to the next line when there is no room, but it moves as one piece. CSS only.Testing
+1/0.+10in one piece (checked in a screenshot).node --checkpasses.