Repository navigation
fix(rewards): list only the selected child's rewards on a tabbed card (#1074) - #1075
Merged
Merged
Conversation
…#1074) With no child_id pinned, every tab listed every reward, so a child was shown a reward assigned only to a sibling, with a claim button the backend then refused. The selected tab now filters the list the way a pinned card does. In the designed styles the tabs stay up when the selected child has nothing, so another child can still be picked.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1074
What was wrong
On a rewards card with no
child_idpinned, every child tab listed every reward, including ones assigned only to a sibling. With that tab selected, the reward showed the selected child's progress and a Claim reward button. The backend then refused the claim, because the reward is not for that child. This was found while testing v6.4.0 on the dev Home Assistant. The behaviour is older than this release.Fix
_rewardsFor()lists the rewards open to everyone plus those assigned to the pinned child or, when nothing is pinned, the selected tab. Both the classic and the designed render paths use it in place of their pinned-only filter.Testing
taskmate-rewards-card.test.cjs, run under classic and playroom: a tab lists only that child's rewards, and the tabs stay when the selected child has none. All 4 fail on main.node --checkpasses.