Repository navigation
feat(chores): "Parent did it" for one child of a shared chore - #1103
Merged
Merged
Conversation
A chore shared by several children can now be marked done by a parent for just one of them. The chore's ⋮ menu in the admin panel lists "Parent did it for everyone" plus "Parent did it for <child>" for each assigned child. parent_complete_chore takes an optional child_id. The completion is still a zero-point "__parent__" record, now with for_child_id, and only that child's recurrence window moves on. Points, streaks, badges and stats already ignore parent completions, so only the places that read one as "done for the pool" (daily quota, due list, today board, child card, sticker chart) needed to honour the new field. Limited to everyone-mode chores, because rotations and first-come have one shared slot. Closes #1096
github-actions
Bot
added
documentation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A chore shared by several children can now be marked done by a parent for
just one of them. The chore's ⋮ menu in the admin panel lists "Parent did it
for everyone" plus "Parent did it for " for each assigned child.
parent_complete_chore takes an optional child_id. The completion is still a
zero-point "parent" record, now with for_child_id, and only that child's
recurrence window moves on. Points, streaks, badges and stats already ignore
parent completions, so only the places that read one as "done for the pool"
(daily quota, due list, today board, child card, sticker chart) needed to
honour the new field. Limited to everyone-mode chores, because rotations and
first-come have one shared slot.
Closes #1096
Tested on the dev instance: marking a shared chore done for one child clears it for that child only; the others still see it as due.