This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Kotlin friendly names#1
Merged
Merged
Conversation
Craigacp
suggested changes
May 17, 2021
Craigacp
left a comment
Craigacp
left a comment
Contributor
There was a problem hiding this comment.
Could you provide some rational for why the method is renamed? Does kotlin treat get methods specially, or is there some conflict with size?
Contributor
Author
|
Yeah, Kotlin will automatically treat |
Craigacp
reviewed
May 17, 2021
Craigacp
approved these changes
May 17, 2021
Craigacp
left a comment
Craigacp
left a comment
Contributor
There was a problem hiding this comment.
I think I'm fine with this, but I'll let @karllessard merge it in case he has comments.
karllessard
suggested changes
May 18, 2021
karllessard
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
Shape.sizetoShape.getand add atoListOrNullmethod. Was part of tensorflow/java#165.