Skip to content

Fix: HTTP Gzip Decompression Bomb DoS #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theteatoast wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: HTTP Gzip Decompression Bomb DoS #4136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tensorflow_serving/util/net_http/server/internal/evhttp_request.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ limitations under the License.

#include "tensorflow_serving/util/net_http/server/internal/evhttp_request.h"

#include <algorithm>
#include <cassert>
#include <cstddef>
#include <cstdint>
Expand Down Expand Up @@ -271,9 +272,13 @@ bool EvHTTPRequest::NeedUncompressGzipContent() {
void EvHTTPRequest::UncompressGzipBody(void* input, size_t input_size,
void** uncompressed_input,
size_t* uncompressed_input_size) {
int64_t max = handler_options_->auto_uncompress_max_size() > 0
? handler_options_->auto_uncompress_max_size()
: ZLib::kMaxUncompressedBytes;
// NEW: Reject suspiciously high compression ratios (> 100x)
static constexpr size_t kMaxCompressionRatio = 100;
static constexpr size_t kMaxDecompressedSize = 10 * 1024 * 1024; // 10MB

int64_t max = std::min(
static_cast<int64_t>(kMaxDecompressedSize),
static_cast<int64_t>(input_size) * kMaxCompressionRatio);

// our APIs don't need expose the actual content-length
*uncompressed_input_size = static_cast<size_t>(max);
Expand Down